[12.0][FIX] website_lazy_load_image: reintroduce missing doctype when recreating html #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contrib! However, it has been fixed here already #719 but the are some issues w/ tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix reintroduce the missing doctype when the html is recreated by the
lxmlparser.When
website_lazy_load_imagemodule is installed, the<!DOCTYPE html>is no more set as a header.It was reported in odoo/odoo#44612
This issue can only by seen by a non-logged user, probably because when logged, an editor module is fixing this issue as a side-effect.
A backport fix for 11.0 will be necessary.