Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] website_mass_mailing_double_opt_in #894

Closed
wants to merge 1 commit into from
Closed

[15.0][ADD] website_mass_mailing_double_opt_in #894

wants to merge 1 commit into from

Conversation

dsolanki-initos
Copy link
Contributor

No description provided.

@dsolanki-initos dsolanki-initos force-pushed the 15.0-mig-website_mass_mailing_double_opt_in branch from ba32fc5 to 695e079 Compare May 19, 2022 06:07
@dsolanki-initos dsolanki-initos changed the title [15.0][MIG] Website mass mainling double opt in [15.0][MIG] website_mass_mailing_double_opt_in May 19, 2022
@tarteo
Copy link
Member

tarteo commented May 27, 2022

@dsolanki-initos Thanks for your contribution! Can you please add the full comnit history. You can find instruction on how to do that here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0#how-to

@tarteo
Copy link
Member

tarteo commented May 27, 2022

Can you also add some tests, please.

@dsolanki-initos dsolanki-initos changed the title [15.0][MIG] website_mass_mailing_double_opt_in [15.0][ADD] website_mass_mailing_double_opt_in Jun 9, 2022
@dsolanki-initos
Copy link
Contributor Author

Can you also add some tests, please.

Sure i will add

@dsolanki-initos
Copy link
Contributor Author

@antespi can you please review this PR?

@dsolanki-initos
Copy link
Contributor Author

@sergio-teruel Can you please review this PR?

@dsolanki-initos dsolanki-initos force-pushed the 15.0-mig-website_mass_mailing_double_opt_in branch 2 times, most recently from 24b1e1c to a3fcf29 Compare July 11, 2022 12:09
@dsolanki-initos
Copy link
Contributor Author

Can you also add some tests, please.

I have added a test case

ikapasi-initos
ikapasi-initos approved these changes Jul 12, 2022
View reviewed changes
Copy link

@ikapasi-initos ikapasi-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test.
LGTM

@dsolanki-initos
Copy link
Contributor Author

@lasley Can you please review this PR?

@dsolanki-initos dsolanki-initos force-pushed the 15.0-mig-website_mass_mailing_double_opt_in branch from a3fcf29 to 45953ed Compare July 21, 2022 08:57
@dsolanki-initos
Copy link
Contributor Author

@tarteo can you please review this PR?

@dsolanki-initos dsolanki-initos force-pushed the 15.0-mig-website_mass_mailing_double_opt_in branch 3 times, most recently from 76d77cc to b024fca Compare August 4, 2022 07:05
@dsolanki-initos dsolanki-initos force-pushed the 15.0-mig-website_mass_mailing_double_opt_in branch from b024fca to 8ab95b0 Compare August 16, 2022 06:36
@ikapasi-initos ikapasi-initos force-pushed the 15.0-mig-website_mass_mailing_double_opt_in branch 3 times, most recently from 0b7e521 to a63be2c Compare August 22, 2022 05:24
@dsolanki-initos dsolanki-initos force-pushed the 15.0-mig-website_mass_mailing_double_opt_in branch 2 times, most recently from 986ce8f to 11e4dd6 Compare August 24, 2022 13:05
@dsolanki-initos dsolanki-initos force-pushed the 15.0-mig-website_mass_mailing_double_opt_in branch from 11e4dd6 to c625c89 Compare September 1, 2022 06:17
@dsolanki-initos dsolanki-initos force-pushed the 15.0-mig-website_mass_mailing_double_opt_in branch from c625c89 to d52eb3d Compare January 18, 2023 09:15
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 21, 2023
@github-actions github-actions bot closed this Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikapasi-initos ikapasi-initos ikapasi-initos approved these changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsolanki-initos @tarteo @ikapasi-initos