[13.0] Shopfloor Zone Picking: fix zero check #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guewen
changed the title
guewen
force-pushed
the
13.0-fix-zero-check
branch
2 times, most recently
from
a772b6c
to
f8f7451
Compare
The client js application needs the move line's id to confirm or not the zero quantity using "/is_zero". The backend did not send the move line's data when going to the "zero_check" state.
The zero check screen shows 2 buttons: * Confirm stock = 0 * Confirm stock not empty At this point, the normal situation would be that the stock is zero. So "Confirm stock not empty" is confusing, as we do not confirm the expected value of zero.
guewen
force-pushed
the
13.0-fix-zero-check
branch
from
f8f7451
to
e63b973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "zero check"
The client js application needs the move line's id to confirm or not the
zero quantity using "/is_zero". The backend did not send the move
line's data when going to the "zero_check" state.
Improve wording on "zero check" screen
The zero check screen shows 2 buttons:
At this point, the normal situation would be that the stock is zero.
So "Confirm stock not empty" is confusing, as we do not confirm the
expected value of zero.