-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG] shopfloor_batch_automatic_creation #292
[14.0][MIG] shopfloor_batch_automatic_creation #292
Conversation
@@ -110,7 +113,7 @@ def _search_pickings(self, picking_types, user=None, commercial_partner=None): | |||
def _sort(self, pickings): | |||
return pickings.sorted( | |||
lambda picking: ( | |||
-(int(picking.priority) if picking.priority else 1), | |||
-(int(picking.priority) if picking.priority else PRIORITY_NORMAL), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change ? PROCUREMENT_PRIORITIES[0][0]
is "0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mmequignon for your comment. The value 1 used to be Normal
. After below Odoo's change, the Normal
is now 0.
odoo/odoo@e405537#diff-55c6314416a6a400da6acd5018d161a55eeeb0e3008fec8828121e3dd12be0ebL19-R19
ce446b6
to
6dd288a
Compare
This module has no more pending dependency now. |
@hailangvn can you rebase to resolve the conflict? This one is ready to be merged |
6dd288a
to
00d5168
Compare
Thanks @mmequignon and @sebalix for your aproval. This PR has been rebased. |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
It looks like something changed on |
Congratulations, your PR was merged at 55353ab. Thanks a lot for contributing to OCA. ❤️ |
No more pending dependency.