[15.0][MIG]stock_picking_type_shipping_policy: Migration to 15.0 #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... stock_picking_group_by_partner_by_carrier (of
OCA/stock-logistics-workflow).
In stock_picking_group_by_partner_by_carrier, the override of the method
_search_picking_for_assignation adds a domain on:
("move_type", "=", self.group_id.move_type)
(self is the move to assign in a picking).
When the move_type of the procurement group is "direct", the transfer is
normally created with the move_type "direct": when a first move is
assigned to a picking and none is found, it creates one with type
"direct", the second move should find the same and be assigned to it.
This is not what happens, with stock_picking_type_shipping_policy
configured to "force_all_product_ready", as it changes the way the first
stock.picking is created:
def _get_new_picking_values(self):
res = super()._get_new_picking_values()
picking_type = self.mapped("picking_type_id")
if picking_type.shipping_policy == "force_as_soon_as_possible":
res["move_type"] = "direct"
elif picking_type.shipping_policy == "force_all_products_ready":
res["move_type"] = "one"
return res
The first stock.picking is created with a move_type of "one", so when
the second move search a stock.picking, it can't find it as it looks for
a "direct" one.
This glue module changes the domain of the grouping to take into account the
picking type's shipping policy when both modules are installed.
Currently translated at 100.0% (4 of 4 strings) Translation: wms-13.0/wms-13.0-stock_picking_type_shipping_policy Translate-URL: https://translation.odoo-community.org/projects/wms-13-0/wms-13-0-stock_picking_type_shipping_policy/es_MX/
Currently translated at 100.0% (4 of 4 strings) Translation: wms-13.0/wms-13.0-stock_picking_type_shipping_policy Translate-URL: https://translation.odoo-community.org/projects/wms-13-0/wms-13-0-stock_picking_type_shipping_policy/es_AR/
bizzappdev
changed the title
|
Ready for the review |
|
/ocabot migration stock_picking_type_shipping_policy |
gurneyalex
approved these changes
Mar 24, 2023
sebalix
reviewed
Mar 24, 2023
| @@ -3,7 +3,7 @@ | |||
| { | |||
| "name": "Stock Picking Type Shipping Policy", | |||
| "summary": "Define different shipping policies according to picking type", | |||
| "version": "14.0.1.1.0", | |||
| "version": "15.0.1.1.0", | |||
Comment on lines
+18
to
+19
| ("force_as_soon_as_possible", "Force to as soon as possible"), | ||
| ("force_all_products_ready", "Force to when all products are ready"), |
There was a problem hiding this comment.
IMO we could ease the mapping to one or direct value by redefining these to force_one and force_direct and add a migration script. Not blocking though, but please add in the roadmap if we don't do it in this version.
bizzappdev
force-pushed
the
15.0-mig-stock-picking-type-shipping-policy-BAD-SIP
branch
from
f0dec16
to
d660a85
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.