[16.0][MIG] - shopfloor #679

sbejaoui · 2023-07-17T14:41:17Z

needs:

jbaudoux · 2023-10-11T10:12:57Z

@sbejaoui Why you dropped the migration scripts ?

sbejaoui · 2023-10-11T10:25:43Z

@sbejaoui Why you dropped the migration scripts ?

Based on the migration procedure, migration scripts should be about the new version, and the scripts for the old versions should be removed (as it's supposed to have been executed already).

jbaudoux · 2023-10-11T11:37:14Z

@sbejaoui Why you dropped the migration scripts ?

Based on the migration procedure, migration scripts should be about the new version, and the scripts for the old versions should be removed (as it's supposed to have been executed already).

Ah thanks for the info :)

lmignon · 2023-12-03T08:04:24Z

shopfloor/services/cluster_picking.py

+        for picking in lines.batch_id.picking_ids:
+            picking_lines = lines.filtered(lambda l, p=picking: l.picking_id == p)
+            self._unload_set_picking_to_done(picking, picking_lines)
+
+    def _unload_set_picking_to_done(self, picking, picking_lines):
+        if picking.state == "done":
+            return
+        # We set the picking to done only when the last line is
+        # unloaded to avoid backorders.
+        if all(line.shopfloor_unloaded for line in picking.move_line_ids):
+            picking._action_done()
        if self.work.menu.unload_package_at_destination:
-            lines.result_package_id = False
+            picking_lines.result_package_id = False


@sbejaoui It's difficult to know what's the semantic behind this new method '_unload_set_picking_to_done'. In your change, you still iterate multi times n the lines.....

from collections import namedtuple def _unload_write_destination_on_lines(self, lines, location): lines.write({"shopfloor_unloaded": True, "location_dest_id": location.id}) lines.package_level_id.location_dest_id = location LineIdsByPickingValue = namedtuple("LINESBYP", ["ids", "all_unloaded_status"]) bypicking = {} for line in lines: if line.picking_id.state == "done": continue value = lines_by_picking_value[line.picking_id] if value: value = LineIdsByPickingValue(ids = value.ids + line.ids, all_unloaded_status = value.all_unloaded_status and line.shopfloor_unloaded) else: value = LineIdsByPickingValue(ids=line.ids, all_unloaded_status=line.shopfloor_unloaded) lines_by_picking_value[line.picking_id] = value for picking, line_values in lines_by_picking_value.items(): if line_values.all_unloaded_status: picking._action_done() if self.work.menu.unload_package_at_destination: self.env["stock.move.line"].browse(line_values.ids).write({"result_package_id" : False})

This refactoring has the purpose of separating the picking validation from the line location update. The idea behind it is to enable the addition of custom behavior during picking validation. Your proposition won't help, as we are still handling all picking in the same method

sbejaoui · 2023-12-03T08:37:24Z

shopfloor/services/cluster_picking.py

-            picking_lines = picking.mapped("move_line_ids")
-            if all(line.shopfloor_unloaded for line in picking_lines):
-                picking._action_done()
+        for picking in lines.batch_id.picking_ids:


@lmignon ,I replaced the loop on the lines with a loop on the pickings. I don't understand how it iterates multiple times on the lines

jbaudoux · 2024-01-17T12:48:18Z

shopfloor/services/location_content_transfer.py

+        # If a move line reference a move linked to others move lines (different
+        # locations), we have to split the move to process only the lines related to
+        # the current location.
        move_line._extract_in_split_order({"user_id": self.env.uid})


How is that possible as when you scan the location at the start, you isolate the move lines from that location in a split order? So at this stage inside the picking we should only have move lines from that location.

In set_destination_all and set_destination_package, I think such is not done. We should have the same behavior in all 3 cases.

I would have dropped that line also unless you can reproduce the use case.

cc @TDu @sebalix

It's required by a test (https://github.com/OCA/wms/pull/679/files#diff-d468159958b3bfcb32afaa09c6a77a69e1811aa92d2abe6d4022f1be66a9ad19R637) but reading the code, It seems that the test is not right since the move_line to process is not selected by using the scan_location method and therefore the initial split is not done... I'll fix the test and remove the line.

@jbaudoux It's fixed into the last commit dbab97d

rousseldenis · 2024-03-13T12:56:31Z

/ocabot migration shopfloor

When an inventory is created and must be validated, the 'inventory_quantity_set' field is set to True on the quant

lmignon · 2024-05-02T08:45:08Z

@rousseldenis @jbaudoux This one is finally 🟢 Can we proceed to the merge so I can move forward with others PRs and thereafter forward port the last changes from 14.0

lmignon · 2024-05-02T08:47:23Z

An important element for the future. Shopfloor should be split into several smaller modules (1 per scenario). The current approach is not healthy for maintenance.

rousseldenis · 2024-05-02T08:53:18Z

shopfloor/actions/inventory.py

@@ -51,8 +51,10 @@ def _get_existing_quant(self, location, product, package=None, lot=None, limit=1
            domain.append(("lot_id", "=", False))
        return self.inventory_model.search(domain, limit=limit)

-    def _create_draft_inventory(self, location, product, lot=None):
-        quants = self._get_existing_quant(location, product, lot=lot, limit=None)
+    def _create_draft_inventory(self, location, product, package=None, lot=None):


This should be completed with owner_id field too.

maybe after the forward port from v14

lmignon · 2024-05-02T09:29:46Z

ping @simahawk Can we merge this.... It works in production for months (cluster + location_content) and we want to finalize all the pending PRs on shopfloor for v16 and forward port the last changes from v14 to have both branches aligned.

rousseldenis · 2024-05-02T12:03:15Z

Let's merge this one. It will allow to do enhancements in separate PR's.

/ocabot merge nobump

OCA-git-bot · 2024-05-02T12:03:24Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-679-by-rousseldenis-bump-nobump, awaiting test results.

Signed-off-by rousseldenis

OCA-git-bot · 2024-05-02T12:20:45Z

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-679-by-rousseldenis-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Makes the sorting of stock move line more predictable if move lines share the same attributes

rousseldenis · 2024-05-02T14:19:41Z

/ocabot merge nobump

OCA-git-bot · 2024-05-02T14:19:56Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-679-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot · 2024-05-02T14:53:12Z

Congratulations, your PR was merged at 434a25d. Thanks a lot for contributing to OCA. ❤️

sbejaoui force-pushed the 16.0-shopfloor-sbj branch 4 times, most recently from 65cb513 to 4a4c669 Compare July 17, 2023 15:30

sbejaoui marked this pull request as draft July 17, 2023 16:38

sbejaoui mentioned this pull request Jul 28, 2023

[16.0][MIG] - shopfloor_workstation #693

Merged

sbejaoui force-pushed the 16.0-shopfloor-sbj branch from c798905 to 3042604 Compare July 31, 2023 07:09

This was referenced Jul 31, 2023

[16.0][MIG] - shopfloor_mobile #698

Merged

[16.0][MIG] - shopfloor_batch_automatic_creation #703

Merged

sbejaoui force-pushed the 16.0-shopfloor-sbj branch from a9d4c4e to b88249c Compare August 10, 2023 14:41

sbejaoui force-pushed the 16.0-shopfloor-sbj branch 5 times, most recently from 6c74ad3 to 0d339e8 Compare August 22, 2023 17:24

sbejaoui force-pushed the 16.0-shopfloor-sbj branch 2 times, most recently from f1a4615 to a5062fc Compare December 2, 2023 20:45

lmignon reviewed Dec 3, 2023

View reviewed changes

sbejaoui commented Dec 3, 2023

View reviewed changes

jbaudoux reviewed Jan 17, 2024

View reviewed changes

lmignon force-pushed the 16.0-shopfloor-sbj branch from a5c06eb to dbab97d Compare January 17, 2024 14:41

lmignon force-pushed the 16.0-shopfloor-sbj branch from dbab97d to 268f402 Compare January 24, 2024 14:43

rousseldenis force-pushed the 16.0-shopfloor-sbj branch from f72f726 to 8bc111b Compare March 13, 2024 12:55

rousseldenis marked this pull request as ready for review March 13, 2024 12:56

rousseldenis added migration needs review labels Mar 13, 2024

lmignon added 7 commits May 2, 2024 09:15

[FIX] pylint

2005d1e

[FIX] shopfloor: Uses inventory to change package lot

550c532

[FIX] shopfloor: Properly manage packages into checkout

d07d827

[FIX] shopfloor: cluster_picking: is_zero tests

c865224

When an inventory is created and must be validated, the 'inventory_quantity_set' field is set to True on the quant

[FIX] shopfloor: Fix checkout tests

43a6ad4

[FIX] shopfloor: Fix delivery tests

3abb26e

[FIX] shopfloor: Fix location_content_transfer tests

5d27a4e

lmignon force-pushed the 16.0-shopfloor-sbj branch from c36df2f to 3edc0d3 Compare May 2, 2024 07:15

[FIX] shopfloor: Fix zone_picking tests

7aa1275

lmignon force-pushed the 16.0-shopfloor-sbj branch from 3edc0d3 to 7aa1275 Compare May 2, 2024 08:33

shopfloor: acsone as contributor

a425d28

rousseldenis approved these changes May 2, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label May 2, 2024

OCA-git-bot added a commit that referenced this pull request May 2, 2024

Merge PR #679 into 16.0

2bc2bcb

Signed-off-by rousseldenis

OCA-git-bot removed the bot is merging ⏳ label May 2, 2024

[FIX] shopfloor: zone_picking: Predictable sort

0b86e6e

Makes the sorting of stock move line more predictable if move lines share the same attributes

OCA-git-bot added the bot is merging ⏳ label May 2, 2024

OCA-git-bot merged commit adc1916 into OCA:16.0 May 2, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 2, 2024

lmignon deleted the 16.0-shopfloor-sbj branch May 2, 2024 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] - shopfloor #679

[16.0][MIG] - shopfloor #679

sbejaoui commented Jul 17, 2023 •

edited

Loading

jbaudoux commented Oct 11, 2023

sbejaoui commented Oct 11, 2023 •

edited

Loading

jbaudoux commented Oct 11, 2023

lmignon Dec 3, 2023 •

edited

Loading

sbejaoui Dec 3, 2023

sbejaoui Dec 3, 2023

jbaudoux Jan 17, 2024 •

edited

Loading

lmignon Jan 17, 2024

lmignon Jan 17, 2024

rousseldenis commented Mar 13, 2024

lmignon commented May 2, 2024

lmignon commented May 2, 2024 •

edited

Loading

rousseldenis May 2, 2024

lmignon May 2, 2024

lmignon commented May 2, 2024

rousseldenis commented May 2, 2024

OCA-git-bot commented May 2, 2024

OCA-git-bot commented May 2, 2024

rousseldenis commented May 2, 2024

OCA-git-bot commented May 2, 2024

OCA-git-bot commented May 2, 2024

[16.0][MIG] - shopfloor #679

[16.0][MIG] - shopfloor #679

Conversation

sbejaoui commented Jul 17, 2023 • edited Loading

jbaudoux commented Oct 11, 2023

sbejaoui commented Oct 11, 2023 • edited Loading

jbaudoux commented Oct 11, 2023

lmignon Dec 3, 2023 • edited Loading

Choose a reason for hiding this comment

sbejaoui Dec 3, 2023

Choose a reason for hiding this comment

sbejaoui Dec 3, 2023

Choose a reason for hiding this comment

jbaudoux Jan 17, 2024 • edited Loading

Choose a reason for hiding this comment

lmignon Jan 17, 2024

Choose a reason for hiding this comment

lmignon Jan 17, 2024

Choose a reason for hiding this comment

rousseldenis commented Mar 13, 2024

lmignon commented May 2, 2024

lmignon commented May 2, 2024 • edited Loading

rousseldenis May 2, 2024

Choose a reason for hiding this comment

lmignon May 2, 2024

Choose a reason for hiding this comment

lmignon commented May 2, 2024

rousseldenis commented May 2, 2024

OCA-git-bot commented May 2, 2024

OCA-git-bot commented May 2, 2024

rousseldenis commented May 2, 2024

OCA-git-bot commented May 2, 2024

OCA-git-bot commented May 2, 2024

sbejaoui commented Jul 17, 2023 •

edited

Loading

sbejaoui commented Oct 11, 2023 •

edited

Loading

lmignon Dec 3, 2023 •

edited

Loading

jbaudoux Jan 17, 2024 •

edited

Loading

lmignon commented May 2, 2024 •

edited

Loading