Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] stock_available_to_promise_release: Refactor release_ready compute #815

Merged

Conversation

jbaudoux
Copy link
Contributor

@jbaudoux jbaudoux commented Jan 17, 2024

Fix missing migration of last commit in #808

@RodrigoBM @lmignon @sbejaoui @mt-software-de

@RodrigoBM
Copy link
Contributor

Why does the test give error if it is corrected?

@mt-software-de
Copy link
Contributor

Why does the test give error if it is corrected?

Good question. And why it was not raised here #808

@jbaudoux jbaudoux force-pushed the 16-stock_available_to_promise_release-mig-refactor branch from c0e999b to eeaffba Compare January 17, 2024 16:08
@jbaudoux jbaudoux force-pushed the 16-stock_available_to_promise_release-mig-refactor branch from eeaffba to c6fc246 Compare January 18, 2024 08:17
@RodrigoBM
Copy link
Contributor

RodrigoBM commented Jan 18, 2024

Why does the test give error if it is corrected?

Good question. And why it was not raised here #808

I think the CI is running v16.0 code and not PR code. is it possible @sbidoul?

@sbidoul
Copy link
Member

sbidoul commented Jan 18, 2024

It's not normal indeed that stock_available_to_promise_release is installed in that preparation step. I'll have a look.

@sbidoul
Copy link
Member

sbidoul commented Jan 18, 2024

I see. It's a case of circular dependencies between repos.

Something here in OCA/wms depends on stock_move_auto_assign_auto_release (in OCA/stock-logistics-warehouse), which itself depends on stock_available_to_promise_release here in OCA/wms. This causes odoo-addon-stock_available_to_promise_release to be installed from PyPI in the preparation step. This would normally not be an issue, but since the released version does not even install we are stuck.

Strictly speaking it's a bug in OCA/oca-ci. I'll think about a solution.

@sbidoul
Copy link
Member

sbidoul commented Jan 18, 2024

It's not normal indeed that stock_available_to_promise_release is installed in that preparation step.

So to be precise, it is normal that it is installed in the preparation step, but we need to install the version of this repo.

@jbaudoux
Copy link
Contributor Author

@sbidoul Thanks for the analysis. Can we already merge this PR? The tests are ok in local.

@sbidoul sbidoul merged commit 97ef32b into OCA:16.0 Jan 18, 2024
3 of 5 checks passed
@sbidoul
Copy link
Member

sbidoul commented Jan 18, 2024

Merged manually to unblock. I'll need some time to test a proper fix for the CI.

@RodrigoBM
Copy link
Contributor

Merged manually to unblock. I'll need some time to test a proper fix for the CI.

But @sbidoul if this is already merged why is it still giving error in my PR. I think there is something that I don't understand about CI!

Thank you very much for your time!!

@sbidoul
Copy link
Member

sbidoul commented Jan 18, 2024

When we merge manually, we need to wait for the nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants