Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixture for root not most recent version #91

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Add fixture for root not most recent version #91

merged 1 commit into from
Apr 25, 2021

Conversation

pwinckles
Copy link
Contributor

Fixture for root inventory not most recent inventory

@zimeon
Copy link
Collaborator

zimeon commented Apr 20, 2021 

(py38) simeon@RottenApple fixtures> ../ocfl-validate.py 1.0/bad-objects/E046_root_not_most_recent
[E001b] OCFL Object root contains unexpected directory: v2 (see https://ocfl.io/1.0/spec/#E001)
INFO:ocfl.object:OCFL object at 1.0/bad-objects/E046_root_not_most_recent is INVALID

zimeon
zimeon approved these changes Apr 20, 2021
View reviewed changes
Copy link
Collaborator

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the error code as somewhat debatable, E046 seems fine and quite helpful. My validator reports E001 because after understanding head as v1 it then decides a v2 directory is spurious

@zimeon zimeon requested a review from awoods April 20, 2021 16:33
@zimeon zimeon mentioned this pull request Apr 20, 2021
Closed
@awoods awoods merged commit 77af971 into OCFL:main Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimeon zimeon zimeon approved these changes

@awoods awoods awoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwinckles @zimeon @awoods