Create v1.1 fixtures tree #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeon
requested review from
rosy1280,
awoods,
julianmorley and
neilsjefferies
Closed
|
OK... when initially creating this I forgot to make a bunch of changes:
Have now fixed these up and the 1.1 objects pass my validator at least |
awoods
approved these changes
Oct 25, 2021
neilsjefferies
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we now have changes that differentiate between 1.0 and 1.1 in error codes etc. (e.g. OCFL/spec#537 (comment)) I think we need to have a separate 1.1 tree. I will make PRs to remove cases from 1.0 that we decided are unclear per that spec, but make sure a clear case is in 1.1