Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type:Version, change inventory type to URI #279

Merged
merged 1 commit into from
Dec 1, 2018
Merged

Remove type:Version, change inventory type to URI #279

merged 1 commit into from
Dec 1, 2018

Conversation

zimeon
Copy link
Contributor

@zimeon zimeon commented Nov 21, 2018

Fixes #232

rosy1280
rosy1280 approved these changes Dec 1, 2018
View reviewed changes
Copy link
Contributor

@rosy1280 rosy1280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this because it seems human readable, but frankly I need to see not in GitHub.

@ahankinson ahankinson merged commit b6844d1 into master Dec 1, 2018
@ahankinson ahankinson deleted the issue-232 branch December 31, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahankinson ahankinson ahankinson approved these changes

@awoods awoods awoods approved these changes

@rosy1280 rosy1280 rosy1280 approved these changes

@julianmorley julianmorley Awaiting requested review from julianmorley

@neilsjefferies neilsjefferies Awaiting requested review from neilsjefferies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zimeon @rosy1280 @awoods @ahankinson