-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imp Notes final updates for #367 #391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianmorley
approved these changes
Oct 3, 2019
rosy1280
requested review from
awoods,
zimeon,
rosy1280,
ahankinson and
julianmorley
October 3, 2019 23:09
julianmorley
previously approved these changes
Oct 3, 2019
zimeon
previously requested changes
Oct 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content seems good, minor formatting issues
eocarragain
reviewed
Oct 7, 2019
eocarragain
reviewed
Oct 7, 2019
eocarragain
reviewed
Oct 7, 2019
rosy1280
requested changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some editorial changes and typos need to be fixed.
rosy1280
previously approved these changes
Oct 8, 2019
awoods
approved these changes
Oct 9, 2019
rosy1280
approved these changes
Oct 9, 2019
ahankinson
approved these changes
Oct 9, 2019
zimeon
approved these changes
Oct 9, 2019
julianmorley
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Example for Updating OCFL to align more with #367 discussion points not covered by other PRs