Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp Notes final updates for #367 #391

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Conversation

neilsjefferies
Copy link
Member

Updated Example for Updating OCFL to align more with #367 discussion points not covered by other PRs

julianmorley
julianmorley previously approved these changes Oct 3, 2019
zimeon
zimeon previously requested changes Oct 3, 2019
Copy link
Contributor

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content seems good, minor formatting issues

draft/implementation-notes/index.html Outdated Show resolved Hide resolved
draft/implementation-notes/index.html Outdated Show resolved Hide resolved
draft/implementation-notes/index.html Show resolved Hide resolved
draft/implementation-notes/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@rosy1280 rosy1280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some editorial changes and typos need to be fixed.

rosy1280
rosy1280 previously approved these changes Oct 8, 2019
@rosy1280 rosy1280 self-requested a review October 9, 2019 15:09
@julianmorley julianmorley merged commit 1275fc6 into master Oct 9, 2019
@neilsjefferies neilsjefferies deleted the Imp-Notes-Update-Example branch May 14, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants