Make sure lat/lon values are rounded to uniform precision #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isatotun
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR ensures that all lat/lon values are rounded to the same level of precision in output datasets.
This is in response to an issue between the mars and aws SEAS5 outputs. I'm still not sure exactly where this was introduced, but the output COGs from the mars data had lat/lon values that were very slightly (ie. 10e-13 order of magnitude) off from the AWS outputs (which had coords precise to 1 decimal point). This caused issues when trying to concatenate the datasets. This discrepancy is in spite of totally matching CRS and input extents.
See more exploration in the
.mdfile included in this PR.I'm not convinced it's a perfect solution, but rounding to 4 decimal places seems to fix the issue, and I don't think gets rid of any precision that we actually care about.
Closes #14