Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No file extensions for bagged workspaces #332

Closed
tboenig opened this issue Oct 11, 2019 · 2 comments
Closed

No file extensions for bagged workspaces #332

tboenig opened this issue Oct 11, 2019 · 2 comments
Assignees
Labels

Comments

@tboenig
Copy link

tboenig commented Oct 11, 2019

I believe the bag feature from ocrd makes errors in mets-files. I miss the files extension. You can see this on my example.

<mets:file ID="OCR-D-GT-SEG-PAGE_0003" MIMETYPE="application/vnd.prima.page+xml">
<mets:FLocat xlink:href="OCR-D-GT-SEG-PAGE/OCR-D-GT-SEG-PAGE_0003" LOCTYPE="URL"/>
@kba kba changed the title ocrd zip bag -i problem No file extensions for bagged workspaces Oct 14, 2019
@kba
Copy link
Member

kba commented Oct 14, 2019

To clarify: The problem is two-fold:

  1. When bagging a file without extension, no extension will be added
  2. Extensions are added to the actual file on the actual file system but not in the xlink:href in some, to be determined, circumstances.

@kba kba added the bug label Oct 14, 2019
@kba kba self-assigned this Oct 14, 2019
kba added a commit to kba/ocrd-core that referenced this issue Oct 23, 2019
@kba
Copy link
Member

kba commented Oct 23, 2019

The problem here was an outdated version of core.

I have a fix for 1) with kba@0a871ea but I am not sure about the ramifications so I am reluctant to integrate it until we have a real use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants