Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page validator to check/fix consistency, spec#82 #223

Merged
merged 8 commits into from
Dec 20, 2018

Conversation

kba
Copy link
Member

@kba kba commented Dec 17, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 17, 2018

Codecov Report

Merging #223 into master will increase coverage by 1.35%.
The diff coverage is 70.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   52.66%   54.01%   +1.35%     
==========================================
  Files          30       31       +1     
  Lines        1447     1555     +108     
  Branches      255      284      +29     
==========================================
+ Hits          762      840      +78     
- Misses        612      629      +17     
- Partials       73       86      +13
Impacted Files Coverage Δ
ocrd/cli/workspace.py 0% <0%> (ø) ⬆️
ocrd/validator/__init__.py 100% <100%> (ø) ⬆️
ocrd/validator/report.py 75% <100%> (+2.27%) ⬆️
ocrd/validator/workspace_validator.py 54.02% <54.54%> (-1.11%) ⬇️
ocrd/validator/page_validator.py 72.34% <72.34%> (ø)
ocrd/model/ocrd_page.py 70.83% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f122d10...42853ac. Read the comment docs.

Copy link
Contributor

@wrznr wrznr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, looking very good. Some comments on the general design.

ocrd/validator/page_validator.py Show resolved Hide resolved
ocrd/validator/page_validator.py Outdated Show resolved Hide resolved
ocrd/validator/page_validator.py Outdated Show resolved Hide resolved
@kba kba merged commit e0be2f8 into OCR-D:master Dec 20, 2018
@kba kba deleted the page-consistency branch December 20, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants