Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic of file downloading, #227 #232

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Conversation

kba
Copy link
Member

@kba kba commented Feb 25, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

Merging #232 into master will decrease coverage by 0.15%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage     100%   99.84%   -0.16%     
==========================================
  Files          30       30              
  Lines        1261     1258       -3     
  Branches      247      246       -1     
==========================================
- Hits         1261     1256       -5     
- Misses          0        1       +1     
- Partials        0        1       +1
Impacted Files Coverage Δ
..._validators/ocrd_validators/workspace_validator.py 100% <100%> (ø) ⬆️
ocrd_models/ocrd_models/ocrd_file.py 100% <100%> (ø) ⬆️
ocrd/ocrd/constants.py 100% <100%> (ø) ⬆️
ocrd_models/ocrd_models/ocrd_mets.py 100% <100%> (ø) ⬆️
ocrd/ocrd/resolver.py 100% <100%> (ø) ⬆️
ocrd/ocrd/workspace.py 97.61% <90%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc83d9...da2cf7c. Read the comment docs.

@kba kba merged commit da2cf7c into OCR-D:master Feb 26, 2019
@kba kba deleted the fix-file-download branch August 14, 2019 08:49
bertsky pushed a commit to bertsky/core that referenced this pull request Apr 26, 2023
make check: skip trying ocrd-make -h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants