Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set LOCTYPE and OTHERLOCTYPE as necessary, fix #310 #328

Merged
merged 4 commits into from
Oct 24, 2019
Merged

Conversation

kba
Copy link
Member

@kba kba commented Oct 9, 2019

This will allow setting @LOCTYPE and @OTHERLOCTYPE.

Default for @LOCTYPE is OTHER and implies @OTHERLOCTYPE = "file" for now.

Setting @LOCTYPE to something different from OTHER will unset @OTHERLOCTYPE.

@kba kba requested a review from wrznr October 22, 2019 17:49
@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #328 into master will decrease coverage by 0.4%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   91.12%   90.72%   -0.41%     
==========================================
  Files          30       30              
  Lines        1622     1649      +27     
  Branches      313      319       +6     
==========================================
+ Hits         1478     1496      +18     
- Misses        108      112       +4     
- Partials       36       41       +5
Impacted Files Coverage Δ
..._validators/ocrd_validators/workspace_validator.py 87.39% <100%> (ø) ⬆️
ocrd_models/ocrd_models/ocrd_file.py 90.9% <82.14%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71eff2...7dadcdd. Read the comment docs.

@kba kba merged commit 949fe4b into OCR-D:master Oct 24, 2019
@kba kba deleted the loctype branch October 24, 2019 10:20
kba added a commit that referenced this pull request Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants