Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch Olena with ImageMagick exception handler #6

Merged
merged 12 commits into from
Aug 22, 2019
Merged

patch Olena with ImageMagick exception handler #6

merged 12 commits into from
Aug 22, 2019

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Aug 16, 2019

fixes #4

@bertsky
make binarize process PAGE-XML (with AlternativeImage):
1b8232b 
- detect whether input file was image/* or PAGE-XML
- for image file, also generate a skeleton PAGE-XML
  (with AlternativeImage for the binarized result)
- for PAGE-XML file, detect namespace (and prefix),
  then check whether AlternativeImage already exists
  or find imageFilename (both on disk and as METS ID),
  process image and add AlternativeImage for result
- reference all new files (image under OCR-D-IMG-BIN,
  PAGE-XML under output fileGrp) in METS
- encapsulate, add pointers for improvement of bashlib
  in core
- improve documentation
@bertsky
fix order of namespace/prefix detection and preserve vs update
46cdb35
@bertsky
added xmlstarlet to deps-ubuntu
809e3aa
@bertsky
fallback to input ID if image not found in METS, and use parsed mets_…
ae6058e 
…file param
@bertsky
use pre-release ocrd; resync travis/Makefile
c4b8880
@bertsky
make output fileGrp for images explicit, update tests
0f1386d
@bertsky
fix comments, add Border cropping:
fef2e6c 
- always reset IFS after customization to avoid
  interference in unexpected places
- when processing a PAGE-XML file which does not
  already have an AlternativeImage, but contains
  Border/PrintSpace, first crop that image before
  binarization
- add "cropped" to comments in that case, and add
  existing commments in the other case
@bertsky
fix adding pageId for output PAGE (inverse condition)
7102bee
@bertsky
fix errexit, ns_prefix can be empty (which is false in xmlstarlet)
5c3fb6d
@bertsky
fallback for out_id in case in_id does not contain input_file_grp
b17b9e6
@bertsky
improve tests:
31efd3f 
- fail immediately if single test not ok
- also check for PAGE result
- add another suite with PAGE input:
  check for PAGE result and cropped image
@bertsky
patch Olena with ImageMagick exception handler
06ac291
This was referenced Aug 16, 2019
Closed
Closed
@bertsky bertsky merged commit 856e021 into OCR-D:master Aug 22, 2019
@bertsky bertsky deleted the fix-4 branch August 22, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrznr wrznr wrznr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImageMagick warnings cause binarization segfaults
2 participants
@bertsky @wrznr