Port to dune #8
Closed
Port to dune #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 tasks
|
Hi @klakplok, did you find some time to look at the PR? We'll gladly help with any changes that are necessary to help the upstreaming of the dune port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR ports ocp-ocamlres to Dune. The initial motivation is to make ocp-ocamlres compatible with
opam-monoreposo it can be used inside Tezos.The PR ports the build rules to a dune file but also changes API of the library to avoid exposing multiple top-level modules. The modules of the library are exposed under the
OCamlRestop-level module.Let me know if you'd rather keep the API unwrapped, I can propose a simplified version of this PR 🙂
Thanks!