Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage improvement #96

Closed
wants to merge 24 commits into from
Closed

Test coverage improvement #96

wants to merge 24 commits into from

Conversation

epatrizio
Copy link
Collaborator

No description provided.

zapashcanon
zapashcanon reviewed Jan 5, 2024
View reviewed changes
src/cmd_opt.ml Outdated Show resolved Hide resolved
zapashcanon
zapashcanon reviewed Jan 5, 2024
View reviewed changes
test/optimize/dune Outdated Show resolved Hide resolved
zapashcanon
zapashcanon reviewed Jan 5, 2024
View reviewed changes
test/sym/dune Outdated Show resolved Hide resolved
zapashcanon
zapashcanon reviewed Jan 8, 2024
View reviewed changes
src/cmd_sym.ml Outdated Show resolved Hide resolved
zapashcanon
zapashcanon reviewed Jan 8, 2024
View reviewed changes
test/sym/binop_i32.wast Outdated Show resolved Hide resolved
zapashcanon
zapashcanon reviewed Jan 9, 2024
View reviewed changes
test/sym/assume.t Outdated Show resolved Hide resolved
zapashcanon
zapashcanon reviewed Jan 9, 2024
View reviewed changes
src/cmd_sym.ml Outdated Show resolved Hide resolved
@epatrizio epatrizio mentioned this pull request Jan 10, 2024
Closed
zapashcanon
zapashcanon reviewed Jan 11, 2024
View reviewed changes
test/sym/assume.wast Outdated Show resolved Hide resolved
zapashcanon
zapashcanon reviewed Jan 15, 2024
View reviewed changes
test/sym/binop_f64.wast

;; File "src/symbolic_value.ml", line 508, characters 24-30: Assertion failed
;; (f64.eq (f64.copysign (local.get $x) (f64.const 42)) (f64.const 0))
;; (if (then unreachable))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you still have to open an issue so we can track this.

zapashcanon
zapashcanon reviewed Jan 15, 2024
View reviewed changes
test/sym/unop_f32.wast
(if (then unreachable))

;; owi: internal error, uncaught exception:
;; File "src/symbolic_value.ml", line 420, characters 18-24: Assertion failed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

zapashcanon
zapashcanon reviewed Jan 15, 2024
View reviewed changes
test/sym/binop_f32.wast
(f32.eq (f32.max (local.get $x) (f32.const 42)) (f32.const 0))
(if (then unreachable))

;; File "src/symbolic_value.ml", line 436, characters 24-30: Assertion failed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

zapashcanon
zapashcanon reviewed Jan 16, 2024
View reviewed changes
test/sym/memory.wast Outdated Show resolved Hide resolved
@zapashcanon
Copy link
Member

On the main branch there is a test/sym/grow.wast now, once you re-based don't forget to add it to the list of cram tests. :)

@filipeom
Copy link
Collaborator

On the main branch there is a test/sym/grow.wast now, once you re-based don't forget to add it to the list of cram tests. :)

Or just create a test to check for out of bounds with a symbolic memory grow. I didn't pay much consideration for formatting when writing the test so it might be ugly

This was referenced Jan 22, 2024
Merged
Closed
@zapashcanon
Copy link
Member

Merged as part of #119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zapashcanon zapashcanon zapashcanon left review comments

@filipeom filipeom filipeom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epatrizio @zapashcanon @filipeom