Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing individual entries from the API #155

Closed
PhatWabbit opened this issue Apr 5, 2018 · 5 comments
Closed

Editing individual entries from the API #155

PhatWabbit opened this issue Apr 5, 2018 · 5 comments

Comments

@PhatWabbit
Copy link

Hi there,

I want to change the VariableCode of a variable that I created a while back - is there any way to do this from the API?

Thanks,
Dan W

@horsburgh
Copy link
Member

@PhatWabbit - I'm not sure we built out all of the update functions on the API yet. We focused first on the read and create functions. @emiliom and @lsetiawan - do you have any additional thoughts on this?

@emiliom
Copy link
Member

emiliom commented Apr 6, 2018

That's correct. The update services (https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/services/updateService.py) have not been fleshed out, for the most part.

My suggestion would be to reuse the connection setup at the start of an odm2api session, then construct and issue a direct SQL UPDATE statement. Roughly, this would look something like this:

from odm2api.ODMconnection import dbconnection

session_factory = dbconnection.createConnection('postgresql', **db_cred)
DBSession = session_factory.getSession()

sq_str = " UPDATE mytable SET variablecode = 'xyz' WHERE variablecode = 'abc' "
DBSession.execute(sql_str)
DBSession.commit()

@emiliom
Copy link
Member

emiliom commented Sep 15, 2018

We should probably close this issue. @aufdenkampe and @horsburgh, what do you think?

If you think the code snippet I included is useful enough, we could think about folding it somewhere into the Sphinx documentation.

@aufdenkampe
Copy link
Member

@emiliom, I like your idea of including your #155 (comment) into the Sphinx documentation. I was recently looking at this with @roelofversteeg and @erekalper and noticing that those functions were indeed in need or work and documentation. It would be good to include that message in the docs.

@emiliom
Copy link
Member

emiliom commented Oct 18, 2018

Adding this example to the Sphinx docs now, so I'm closing the issue.

@emiliom emiliom closed this as completed Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants