Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified test to fail due to decoding error #156

Closed
wants to merge 3 commits into from

Conversation

lsetiawan
Copy link
Member

This should capture the errors in #148. At least, the decode error...

@lsetiawan lsetiawan changed the title Modified test to fail due to encoding error Modified test to fail due to decoding error Jul 12, 2017
@lsetiawan lsetiawan requested a review from ocefpaf July 12, 2017 18:01
@ocefpaf
Copy link
Member

ocefpaf commented Jul 18, 2017

@lsetiawan can you rebase this one so we can see if #158 did the trick for this test?

@lsetiawan
Copy link
Member Author

Hmm... it seems like the test is using WaterML.py rather than WaterML_1_1.py.

@lsetiawan
Copy link
Member Author

After some thinking, since this test_wof.py uses WaterML.py. I will leave it alone and create a new test that uses WaterML_1_1.py since these standards are different. I am closing this PR and will replace with a new PR that deals strictly WOF testing for WaterML 1.1.

@lsetiawan lsetiawan closed this Jul 25, 2017
@lsetiawan lsetiawan deleted the fail_testwof branch July 25, 2017 22:25
@emiliom
Copy link
Member

emiliom commented Jul 26, 2017

It's a good idea to have a test that's based on WaterML 1.1. However, I'm not persuaded the test (which reads XML content, right?) really could stand in for the encoding/decoding tests we were seeing, which you've already fixed, since those involved the additional factor of reading from a database, right? Anyway, closing this PR seems like the right move.

@lsetiawan
Copy link
Member Author

lsetiawan commented Jul 26, 2017

those involved the additional factor of reading from a database, right?

Reading from a database doesn't matter. The issue was due to non latin characters not encoded/decoded properly. test_wof.py is the part where it reads the inputs and serialized it into an xml, similar to what spyned_1_1.py is doing.

I can probably use the backbone of test_wof.py, but rather than comparing the resulting XML, I can just test whether the non-latin character decoded/encoded correctly.

@lsetiawan lsetiawan mentioned this pull request Sep 1, 2017
@ocefpaf ocefpaf mentioned this pull request Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants