Added function to handle errors in database interactions, making server more stable. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like it's also database-agnostic, right? It will work with any of the database systems? Otherwise, it looks good, and all tests are passing. I'll merge after I hear back from you. |
|
@emiliom Let me test on mysql real quick.. It should be. |
|
The PR title says "handle database disconnects", but in reality it's broader than that. Please rename the PR, replacing that phrase with something more generic like "handle errors in database interactions" (otherwise it's hard to backtrack the scope of the PR from its title alone). |
|
@emiliom I have confirmed it is database-agnostic. 👍 |
lsetiawan
changed the title
This was referenced Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses #172 by providing a handling on the error. It is not specific to any Exception so I think this might also addresses #150...
Notes
I tested this by deploying WOFpy then restarting the Database. Originally I would get
OperationalError, but with the handling, the error is not seen.