Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DB #194

Merged
merged 1 commit into from
Sep 25, 2017
Merged

add DB #194

merged 1 commit into from
Sep 25, 2017

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Sep 25, 2017

Not ready yet! Do not merge!!

We won't use the file I commit, we'll wait for a smaller version that @lsetiawan is preparing to avoid bloating the repo.

@lsetiawan not sure how to assess if this worked. At least it did not break Travis-CI 😄

#!/bin/bash

psql -U postgres -c "create extension postgis"
psql -U postgres -q -f ./tests/usecasesql/envirodiy/envirodiy_postgres_odm2.sql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf I think the folder in WOFpy for tests are called test rather than tests. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the tests if you look at the PR b/c I though it would be nice to separate the DB from the tests. But maybe that is not a good idea. I'll merge them.

.travis.yml Outdated
addons:
apt:
packages:
- postgresql-9.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops sorry, this should be combined postgresql-9.1-postgis-2.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a big name 😄
Fixed!

.travis.yml Outdated
@@ -8,7 +8,8 @@ services:
addons:
apt:
packages:
- postgresql-9.1-postgis-2.1
- postgresql-9.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be

addons:
    postgresql: "9.2"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that has a different effect than installing the 9.2 version. According the to logs it used 9.2. But let's try that! After all it is in the docs 😄

.travis.yml Outdated
@@ -8,9 +8,9 @@ services:
- postgresql

addons:
postgresql: "9.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is your spacing incorrect? Travis is failing :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@lsetiawan
Copy link
Member

LGTM! Merging. 😄

@lsetiawan lsetiawan merged commit d796348 into ODM2:master Sep 25, 2017
@ocefpaf ocefpaf deleted the ci-helpers branch September 25, 2017 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants