Performance optimizations for ODM2 timeseries DAO get_variables requests #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored SQLAlchemy queries in get_variables_from_results() to improve performance. Result is dramatic. - Renamed get_match to get_odm2cv_match, for clarity - Other cosmetic tweaks
Updated from deprecated odm2api.ODM2.models module path to odm2api.models path
|
Driven and tested by EnviroDIY ODM2 issues. Broadly related to #228 (that's an umbrella issue). |
Missed it in tests for January, probably b/c I wasn't testing that function
Required for ODM2 timeseries DAO
|
Travis-CI: Getting error in So, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored SQLAlchemy queries in get_variables_from_results() to improve performance. Result is dramatic. Also other small tweaks, including documentation.