Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor #22

Merged
merged 1 commit into from
Aug 27, 2017
Merged

AppVeyor #22

merged 1 commit into from
Aug 27, 2017

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jul 27, 2017

We need to merge #21 first.

(We also need for someone with the rights to this repo to enable AppVeyor.)

@ocefpaf ocefpaf mentioned this pull request Jul 27, 2017
8 tasks
@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 31, 2017

@sreeder can you review, and if you think it is OK merge, this PR?

@ocefpaf
Copy link
Member Author

ocefpaf commented Aug 27, 2017

With #21 merged there are no controversial parts in this PR, only extra testing.

@emiliom and @sreeder could any of you merge this one?

@emiliom
Copy link
Member

emiliom commented Aug 27, 2017

I see it's a simple change (adding appveyor config file) that wouldn't impact anything else, so I'll merge.

Note that @ocefpaf's original PR text included this:

(We also need for someone with the rights to this repo to enable AppVeyor.)

@ocefpaf, is that taken care of, too?

@emiliom emiliom merged commit 28162bc into ODM2:master Aug 27, 2017
@ocefpaf ocefpaf deleted the appveyor branch August 27, 2017 21:13
@ocefpaf
Copy link
Member Author

ocefpaf commented Aug 27, 2017

@ocefpaf, is that taken care of, too?

Kind of. It is running on my own instance only. It would be nice to have an "official" account that we could use to run AppVeyor for ODM2.

@emiliom
Copy link
Member

emiliom commented Aug 27, 2017

Kind of. It is running on my own instance only. It would be nice to have an "official" account that we could use to run AppVeyor for ODM2.

Sounds like a broader discussion. I don't want to clutter this PR. Shoot me an email (cc @lsetiawan ) to let me know what needs to be done, what's being done on WOFpy and other ODM2 repos, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants