Fix invalid partial json generated when serverside paging is applied in multi-level containment scenarios #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in multi-level containment scenarios
ElizabethOkerio
pushed a commit
to ElizabethOkerio/AspNetCoreOData
that referenced
this pull request
May 17, 2023
…ectly (OData#924) And add test cases to verify the collection in collection
ElizabethOkerio
approved these changes
May 17, 2023
habbes
approved these changes
May 17, 2023
| IList<ODataPathSegment> navigationPathSegments = resourceContext.GenerateBaseODataPathSegments(); | ||
| IList<ODataPathSegment> navigationPathSegments; | ||
| if (resourceContext.NavigationSource is IEdmContainedEntitySet && | ||
| resourceContext.NavigationSource != resourceContext.SerializerContext.Path.NavigationSource()) |
There was a problem hiding this comment.
What does this second condition ensure?
There was a problem hiding this comment.
@habbes When resourceContext.NavigationSource is IEdmContainedEntitySet and resourceContext.NavigationSource is equal resourceContext.SerializationContext.Path.NavigationSource(), the GenerateBaseODataPathSegments() is able singly handle that scenario
KenitoInc
approved these changes
May 17, 2023
gathogojr
deleted the
fix/2262-invalid-partial-json-involving-serverside-paging-in-containment-scenarios
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ports this 7.x fix to 8.x