Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for 7.0 Beta1. #1174

Merged
merged 2 commits into from
Dec 21, 2017
Merged

Conversation

robward-ms
Copy link
Contributor

Issues

This pull request makes progress on issues #975, #939, #772, #628, #229.

Description

Release notes for 7.0.0 Beta1.

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed


**Web API OData for ASP.NET Core**, has following limitations which are known issues:
* Batching is not supported
* Using EnableQuery in an HTTP route, i.e. non-ODta route, is not fully functional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: non-ODta -> non-OData

* Batching is not supported
* Using EnableQuery in an HTTP route, i.e. non-ODta route, is not fully functional

**Web API OData for ASP.NET** , there are no known issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space in "ASP.NET** ,"

To get started with OData V7.0.0 for ASP.NET Core 2.x, you can use code that is very similar to Web API OData V6.0.0. All of the
documentation in [Writing a simple OData V4 service](http://odata.github.io/WebApi/#01-02-getting-started) is correct except for
configuring the OData endpoint. Instead of using the Register() method, you'll follow the new service + route configuration model
used in ASP.NET Core.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a MS doc for the service/route configuration in ASP.NET Core that you can link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


#### e. Configure the OData Endpoint

Open the file App_Start/WebApiConfig.cs. Replace the existing `ConfigureServices` and `ConfigureServices` methods with the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate mention of ConfigureServices.

following code:

{% highlight csharp %}
public void ConfigureServices(IServiceCollection services)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space between void and ConfigureServices

}
{% endhighlight %}

In the controller, we defined a `List<Product>` object which has one product element. It's considered as a in-memory storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar nit: "It's considered as an in-memory"

@@ -0,0 +1,140 @@
---
layout: post
title : "14.1 7.x Beta1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have Beta released?
If not, the first one is better to name as "Beta".

Beta1 sounds "Yes, We will have Beta2, please wait".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have a Beta2 to add batching.

---
layout: post
title : "14.1 7.x Beta1"
description: "7.x Beta1 for ASP.NET and ASP.NET Core"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET Classic and ASP.NET Core

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the ASP.NET docs, the original version is "ASP.NET": https://www.asp.net/get-started


The namespace for both Web API OData packages is Microsoft.AspNet.OData.

Let's get started by creating a simple OData V4 service. It has one entity set `Products`, one entity type `Product`. `Product`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use some codes is better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll delete this since the code is provided below.

Copy link
Contributor

@AlanWong-MS AlanWong-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and understandable to me. :shipit: 🚀

Copy link
Contributor

@AlanWong-MS AlanWong-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good still, have another squirrel. :shipit:

@robward-ms robward-ms merged commit 9647680 into OData:gh-pages Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants