Fix issue #2712: add overload to set custom uri functions on model scope #2715

xuzhg · 2023-08-07T22:42:07Z

Issues

This pull request fixes #2712.

Description

Add overload to add/remove Customized Uri functions.
The goal is:

Enable customers to add/remove customized uri functions on model scope
Avoid breaking changes
Back-compatibility

Checklist (Uncheck if it is not completed)

Test cases added
Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

pull-request-quantifier-deprecated · 2023-08-07T22:42:12Z

This PR has 118 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Medium
Size       : +72 -46
Percentile : 43.6%

Total files changed: 10

Change summary by file extension:
.txt : +12 -12
.cs : +51 -17
.bsl : +9 -17

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

ElizabethOkerio · 2023-08-08T09:38:39Z

test/PublicApiTests/BaseLine/Microsoft.OData.PublicApi.netstandard2.0.bsl

@@ -7925,7 +7925,6 @@ public enum Microsoft.OData.Client.SaveChangesOptions : int {
    BatchWithSingleChangeset = 1
    BulkUpdate = 128
    ContinueOnError = 2
-    DeepInsert = 256


why this change?

One of previous commit forgot to update the bsl.

test/PublicApiTests/BaseLine/Microsoft.OData.PublicApi.netstandard2.0.bsl

ElizabethOkerio · 2023-08-08T09:39:04Z

test/PublicApiTests/BaseLine/Microsoft.OData.PublicApi.netstandard2.0.bsl

-    public virtual void SetRelatedObject (object source, string sourceProperty, object target)
-    public virtual void SetRelatedObjectLink (object source, string sourceProperty, object target)


KenitoInc · 2023-08-09T07:33:30Z

test/PublicApiTests/BaseLine/Microsoft.OData.PublicApi.net45.bsl

@@ -7925,7 +7925,6 @@ public enum Microsoft.OData.Client.SaveChangesOptions : int {
    BatchWithSingleChangeset = 1
    BulkUpdate = 128
    ContinueOnError = 2
-    DeepInsert = 256


Undo this change since it is unrelated to this PR

One of previous commit forgot to update the bsl.

KenitoInc · 2023-08-09T07:33:36Z

test/PublicApiTests/BaseLine/Microsoft.OData.PublicApi.net45.bsl

@@ -8237,7 +8236,6 @@ public class Microsoft.OData.Client.DataServiceContext {
    public virtual DataServiceQuery`1 CreateQuery (string entitySetName)
    public virtual DataServiceQuery`1 CreateQuery (string resourcePath, bool isComposable)
    public virtual DataServiceQuery`1 CreateSingletonQuery (string singletonName)
-    public virtual Microsoft.OData.Client.DataServiceResponse DeepInsert (T resource)


Undo this change since it is unrelated to this PR

One of previous commit forgot to update the bsl.

KenitoInc · 2023-08-09T07:33:45Z

test/PublicApiTests/BaseLine/Microsoft.OData.PublicApi.net45.bsl

@@ -8304,8 +8302,6 @@ public class Microsoft.OData.Client.DataServiceContext {
    public virtual System.Threading.Tasks.Task`1[[Microsoft.OData.Client.DataServiceResponse]] SaveChangesAsync (System.Threading.CancellationToken cancellationToken)
    public virtual System.Threading.Tasks.Task`1[[Microsoft.OData.Client.DataServiceResponse]] SaveChangesAsync (Microsoft.OData.Client.SaveChangesOptions options, System.Threading.CancellationToken cancellationToken)
    public virtual void SetLink (object source, string sourceProperty, object target)
-    public virtual void SetRelatedObject (object source, string sourceProperty, object target)


Undo this change since it is unrelated to this PR

One of previous commit forgot to update the bsl.

KenitoInc · 2023-08-23T09:17:21Z

Fix the public baseline files
There are tests that are still failing

Fix issue #2712: add overload to set custom uri functions on model scope

b32c248

pull-request-quantifier-deprecated bot added the Medium label Aug 7, 2023

xuzhg requested review from KenitoInc, habbes, mikepizzo, ElizabethOkerio and gathogojr August 7, 2023 22:42

ElizabethOkerio reviewed Aug 8, 2023

View reviewed changes

test/PublicApiTests/BaseLine/Microsoft.OData.PublicApi.netstandard2.0.bsl Show resolved Hide resolved

ElizabethOkerio reviewed Aug 8, 2023

View reviewed changes

ElizabethOkerio approved these changes Aug 8, 2023

View reviewed changes

KenitoInc requested changes Aug 9, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue #2712: add overload to set custom uri functions on model scope #2715

Fix issue #2712: add overload to set custom uri functions on model scope #2715

xuzhg commented Aug 7, 2023

pull-request-quantifier-deprecated bot commented Aug 7, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

ElizabethOkerio Aug 8, 2023

xuzhg Aug 21, 2023

ElizabethOkerio Aug 8, 2023

KenitoInc Aug 9, 2023

xuzhg Aug 21, 2023

KenitoInc Aug 9, 2023

xuzhg Aug 21, 2023

KenitoInc Aug 9, 2023

xuzhg Aug 21, 2023

KenitoInc commented Aug 23, 2023

		public virtual void SetRelatedObject (object source, string sourceProperty, object target)
		public virtual void SetRelatedObjectLink (object source, string sourceProperty, object target)

Fix issue #2712: add overload to set custom uri functions on model scope #2715

Are you sure you want to change the base?

Fix issue #2712: add overload to set custom uri functions on model scope #2715

Conversation

xuzhg commented Aug 7, 2023

Issues

Description

Checklist (Uncheck if it is not completed)

Additional work necessary

pull-request-quantifier-deprecated bot commented Aug 7, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KenitoInc commented Aug 23, 2023