Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tty: serial: 8250: add GUID to hard-coded module alias in 8250_dfl driver #127

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

pcolberg
Copy link
Contributor

The DFHv1 GUID needs to match for automatic loading of the driver.

Fixes: 0e524ef ("tty: serial: 8250: Add the GUID definition for UART")

@pcolberg pcolberg self-assigned this May 31, 2024
@pcolberg pcolberg marked this pull request as ready for review May 31, 2024 18:12
@pcolberg pcolberg requested a review from fpgamatt May 31, 2024 18:12
@pcolberg
Copy link
Contributor Author

pcolberg commented Jun 8, 2024

Testing on RHEL 8.10 with Intel N6001 FPGA card.

Without this patch (bf660d8), 8250_dfl driver does not load automatically:

# lsmod | grep 8250
# dmesg | grep tty
[    0.001000] printk: console [tty0] enabled
[    3.342552] 00:03: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A
[    3.363449] 00:04: ttyS1 at I/O 0x2f8 (irq = 3, base_baud = 115200) is a 16550A
# modprobe 8250_dfl
# dmesg | grep tty
[    0.001000] printk: console [tty0] enabled
[    3.342552] 00:03: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A
[    3.363449] 00:04: ttyS1 at I/O 0x2f8 (irq = 3, base_baud = 115200) is a 16550A

With this patch (1ae9844), 8250_dfl driver loads automatically:

# lsmod | grep 8250
8250_dfl               16384  0
dfl                    32768  8 dfl_pci,uio_dfl,dfl_fme,intel_m10_bmc_pmci,dfl_fme_br,8250_dfl,dfl_afu,dfl_emif
# dmesg | grep tty
[    0.001000] printk: console [tty0] enabled
[    3.363493] 00:03: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A
[    3.384546] 00:04: ttyS1 at I/O 0x2f8 (irq = 3, base_baud = 115200) is a 16550A
[   14.105998] serial8250: ttyS2 at MMIO 0x207fffd60400 (irq = 282, base_baud = 3125000) is a 16550A

@pcolberg pcolberg marked this pull request as draft June 8, 2024 01:43
@pcolberg pcolberg requested a review from fpgamatt June 10, 2024 18:44
@pcolberg pcolberg marked this pull request as ready for review June 10, 2024 18:46
…iver

The DFHv1 GUID needs to match for automatic loading of the driver.

Fixes: 0e524ef ("tty: serial: 8250: Add the GUID definition for UART")
Signed-off-by: Peter Colberg <peter.colberg@intel.com>
@pcolberg pcolberg merged commit c955739 into intel/fpga-ofs-dev-6.6-lts Jun 10, 2024
16 checks passed
@pcolberg pcolberg deleted the pcolberg/8250_dfl branch June 10, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants