Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opae.io: add vf_token subcommand #2984

Merged
merged 2 commits into from
Jul 13, 2023
Merged

opae.io: add vf_token subcommand #2984

merged 2 commits into from
Jul 13, 2023

Conversation

fpgamatt
Copy link
Contributor

Add the vf_token subcommand to set the PCI Virtual Function (VF) token when the vfio-pci driver is bound to the Physical Function (PF).

@fpgamatt fpgamatt self-assigned this Jul 12, 2023
@fpgamatt fpgamatt requested a review from a team as a code owner July 12, 2023 22:13
tswhison
tswhison reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@tswhison tswhison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits.

binaries/opae.io/main.h Outdated Show resolved Hide resolved
binaries/opae.io/main.h Outdated Show resolved Hide resolved
binaries/opae.io/main.h Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5536926562

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.714%
Totals Coverage Status
Change from base Build 5534792758: 0.0%
Covered Lines: 13790
Relevant Lines: 20365
💛 - Coveralls

@fpgamatt fpgamatt force-pushed the mgerlach/vf_token branch 2 times, most recently from f64c687 to 8dce9a5 Compare July 12, 2023 23:29
tswhison
tswhison previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@tswhison tswhison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think of it, since we switched to new [ ], the check on 230 is no longer necessary. The standard C++ new operator will raise an exception if the allocation can't be fulfilled. Feel free to remove 230-233 if you feel so inclined.

tswhison
tswhison previously approved these changes Jul 13, 2023
View reviewed changes
@matthew-gerlach
opae.io: add vf_token subcommand
29997fd 
Add the vf_token subcommand to set the PCI Virtual Function (VF)
token when the vfio-pci driver is bound to the Physical Function
(PF).

Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
@fpgamatt fpgamatt merged commit f477f11 into master Jul 13, 2023
@fpgamatt fpgamatt deleted the mgerlach/vf_token branch July 13, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswhison tswhison tswhison approved these changes

Assignees

@fpgamatt fpgamatt

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fpgamatt @coveralls @tswhison @matthew-gerlach