-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: samples:cxl_hello_fpga : Add support for Hello fpga feature for CMC #3052
Conversation
Pull Request Test Coverage Report for Build 7399486989
💛 - Coveralls |
Since you are adding new C++ files, please use the clang-format tool to uniformly format the sourcecode. Use the following command: |
014f685
to
f3669ab
Compare
f3669ab
to
e162658
Compare
samples:cxl_hello_fpga : Add support for Hello fpga feature for CMC Problem/Feature: A new feature, hello fpga, is introduced for CMC Fix/Workaround: Updates pertaining to hello fpga feature are newly added Changes made: New folder named as cxl_hello_fpga along with required files are
Signed-off-by: Lakshmiravikanth Pammi lakshmiravikanth.pammi@intel.com |
${spdlog_INCLUDE_DIRS}) | ||
|
||
target_compile_options(cxl_hello_fpga PUBLIC | ||
-Wno-unused-result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, why are we masking this warning?
4dff482
to
9a6e358
Compare
9a6e358
to
8a3c374
Compare
samples/CMakeLists.txt: Added cxl_hello_fpga module for compilation samples:cxl_hello_fpga: Added this folder updates pertaining to Hello FPGA feature for CMC Signed-off-by: Lakshmiravikanth Pammi <lakshmiravikanth.pammi@intel.com>
Problem/Feature: 1. A new feature, hello fpga, is introduced for CMC 2. CL bytes format is changed by RTL team Fix/Workaround: 1. Updates pertaining to hello fpga feature are newly added 2. Driver is updated as per the change in CL integrity check format. Changes made: New folder named as cxl_hello_fpga along with required files are introduced for supporting hello_fpga feature 1.Review comments shared by Ananda are added. 2.Clang-format is applied for all source files available in cxl_hello_fpga as suggested by Gerlach, Matthew. 3.Integrity check API is updated as per the new CL format introduced by RTL team Signed-off-by: Lakshmiravikanth Pammi <lakshmiravikanth.pammi@intel.com>
961d828
to
c0665af
Compare
samples:cxl_hello_fpga : Add support for Hello fpga feature for CMC Problem/Feature: 1. A new feature, hello fpga, is introduced for CMC Fix/Workaround: 1. Updates pertaining to hello fpga feature are newly added Changes made: New folder named as cxl_hello_fpga along with required files are
Signed-off-by: Lakshmiravikanth Pammi lakshmiravikanth.pammi@intel.com Test Command: ./bin/cxl_hello_fpga hellofpga Test Result: (root@bapveac041T~/ravikanth/ALPHA/alpha_sws/hello_fpga_231030/hfm_checkin/opae-sdk/mybuild)-> ./bin/cxl_hello_fpga hellofpga |
Please review the above changes and approve to merge the changes into master. |
samples:cxl_hello_fpga : Add support for Hello fpga feature for CMC
Problem/Feature: A new feature, hello fpga, is introduced for CMC
Fix/Workaround: Updates pertaining to hello fpga feature are newly added
Changes made: New folder named as cxl_hello_fpga along with required files are
introduced for supporting hello_fpga feature
Signed-off-by: Lakshmiravikanth Pammi lakshmiravikanth.pammi@intel.com
Test command:
Test Results:
(root@bapveac041T~/ravikanth/ALPHA/alpha_sws/hello_fpga_231030/hfm_checkin/opae-sdk/mybuild)-> ./bin/cxl_hello_fpga hellofpga
starting test run, count of 1
Number nodes on system:3
HE Cache app numa node:1
HE_TARGET_HOST numa node:1
Hello FPGA Start
Read/write number Lines:5
Read address table size:9
Write address table size:9
DSM buffer numa node: 0
Read/Write buffer numa node: 1
AFU Configuration : Successful
Test started ......
DATA Integrity Check : Successful
Hello FPGA Executed Successfully
Test hellofpga(1): PASS
(root@bapveac041T~/ravikanth/ALPHA/alpha_sws/hello_fpga_231030/hfm_checkin/opae-sdk/mybuild)->