Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] - fpgasupdate -- skip Factory check under certain conditions #3063

Merged
merged 11 commits into from
Dec 20, 2023

Conversation

anandhv
Copy link
Contributor

@anandhv anandhv commented Dec 20, 2023

Description

A check was recently added to fpgasupdate to prevent writing to the flash factory page when the current boot-page is also factory. This combo is in fact already prevented in the hardware by the BMC but a vague error message is propagated back to the SW stack. So the purpose of the check in fpgasupdate is to enable printing of a descriptive message to the user.

This check works for n6001 and beyond, and PACSigned binaries, but was shown to fail on D5005 systems and with .gbs files.

The D5005 failure seems to be because the boot-page sysfs entry is missing on such installations.
The .gbs failure is because such binaries are missing the Auth Block0 segment.

This change simply skips the check if either of the above conditions is true. It is OK to skip this because the BMC prevents the combo anyways.

Tests run:

  • Tested on Comet Creek to ensure the check errors-out, as expected, for factory images.
  • Tested on D5005 to ensure programming now completes successfully.
  • Tested on N6001 to ensure programming a .gbs files completes successfully.

@anandhv anandhv requested a review from a team as a code owner December 20, 2023 17:25
Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandhv for the clear commit message! I could fully understand the issue despite having no previous exposure and without having to consult the code.

@anandhv anandhv merged commit 8a6ff0b into OFS:master Dec 20, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants