Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop for loop if mustar candidate found in mu_star_calibration_from_geodetic_mb #1332

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

lilianschuster
Copy link
Member

Inside of mu_star_calibration_from_geodetic_mb, there is a loop to get a mu_star and step (ref_hgt_change) combination. I changed the function in order that the loop actually stops when one suitable combination is found (i.e., the one where we can find a mu_star with the smallest ref_hgt_change possible. Because for this application, we only take the first combination, so stopping the loop just saves hopefully some time!

  • Tests added/passed

@fmaussion fmaussion merged commit 1e42838 into OGGM:master Nov 4, 2021
@fmaussion
Copy link
Member

Thanks @lilianschuster !

@lilianschuster lilianschuster deleted the dev_new branch December 3, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants