Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ERA5L-HMA support #1348

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Fix ERA5L-HMA support #1348

merged 2 commits into from
Dec 7, 2021

Conversation

Keeptg
Copy link
Member

@Keeptg Keeptg commented Dec 4, 2021

  • Tests added/passed
  • Fully documented
  • Entry in whats-new.rst

@pep8speaks
Copy link

pep8speaks commented Dec 4, 2021 •
edited
Loading

Hello @Keeptg! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-12-07 09:49:47 UTC

@fmaussion
Copy link
Member

Thanks @Keeptg ! I think its fine here to only change oggm/core/climate.py and do not test for it.

The tests do not allow downloads from such large data, so it would imply creating test files, etc. - which is too tedious I think.

@Keeptg
Copy link
Member Author

Keeptg commented Dec 7, 2021

@fmaussion Aha, then it will be quite easy. Will update the PR soon!

@fmaussion fmaussion marked this pull request as ready for review December 7, 2021 13:35
@fmaussion fmaussion merged commit 3ed0ba8 into OGGM:master Dec 7, 2021
@fmaussion
Copy link
Member

Thanks!

@Keeptg Keeptg deleted the fix_ERA5L-HMA_support branch December 7, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Keeptg @pep8speaks @fmaussion