Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New MB model calibration architecture #1527

Merged
merged 51 commits into from
Mar 8, 2023
Merged

New MB model calibration architecture #1527

merged 51 commits into from
Mar 8, 2023

Conversation

fmaussion
Copy link
Member

This opens the door to add @lilianschuster 's MB sandbox tools.

Currently only with Monthly model

I added a flexible MB calibration scheme, including the infamous three-step calibration

@fmaussion
Copy link
Member Author

This has become much larger than anticipated, but it feels good. The decommissioning of mu* is now!

@fmaussion
Copy link
Member Author

fmaussion commented Feb 28, 2023

Some todos:

  • override_missing kwarg in the new calibration could accomodate with a dict or a dataframe of values to allow for arbitrary datasets
  • docstrings of the most important functions: calibration, MB models, run_
  • thinking about the naming of functions and parameters really hard as we wont change them back afterwards
  • the merged glacier funcs need multiple flowline parameters - looking into the future someone else might need this. Do we want to try to implement? there are already some ideas here: https://github.com/fmaussion/oggm/blob/0a5b8544b9b89ce8eda43fd0fbe12f36538daa1d/oggm/core/massbalance.py#L591-L598

@fmaussion fmaussion merged commit 410bc78 into OGGM:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants