corrected glacier gridpoints on flattened files #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the now updated flattened GSWP3-W5E5 and ISIMIP3b files (version 2023.2). In the previous version, i.e., at the moment still in here https://cluster.klima.uni-bremen.de/~oggm/test_climate/gswp3-w5e5/flattened/monthly/
and https://cluster.klima.uni-bremen.de/~oggm/cmip6/isimip3b/flat/monthly/, there are around 11900 glaciers that did not select the nearest gridpoint (due to an issue in the glacier gridpoint selection of these files).
The reason why this only got visible now is that I only tested it for Hintereisferner, where it worked. So it can be important to test on more glaciers. In that case, a simple test on all glaciers would have been necessary.
I added a test where I checked it for three glaciers. This test only works with the new (test) flattened files.
I also checked for every glacier, if the right gridpoints are now selected. The tests need to download quite some data and take time, so they are just here: https://nbviewer.org/urls/cluster.klima.uni-bremen.de/~lschuster/example_ipynb/flatten_glacier_gridpoint_tests.ipynb?flush_cache=True
The scripts to create these flattened glacier gridpoint files are
Thanks, @fmaussion, for reporting!
When we are sure that everyone updated to v1.6.1, we should remove the old files with the missing gridpoints.