Adaptations in dynamic calibration functions

[pat-schmitt]

Here I am suggesting some changes in the dynamic calibration functions:

• I changed the default min ice thickness from 10 to 2. I found this in a recent study that with the old default of 10 you are always on the higher end of the target area error boundary. This makes a larger difference for smaller (thinner) glaciers, on the large scale I do not expect to see large differences. Open for discussion! (if we change this should be added to whats-new)

• I slightly changed the order in the code to avoid wrong diagnostic messages in gdir.get_diagnostics() if something fails. But all functionalities stay the same.

• I renamed t_bias to t_spinup in the dynamic calibration procedure, to avoid confusion with the temperature bias of the mass balance model (suggestion from @rodaguayo)

• Tests added/passed

• Fully documented

• Entry in whats-new.rst

[pep8speaks]

Hello @pat-schmitt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-01 16:37:20 UTC

[fmaussion]

Thanks @pat-schmitt ! I agree with the change in defaults - please add whats new and merge

[pat-schmitt]

It seems this got stock with 'Processing updates'. I will close and reopen again.