distribute2d: introduce only_allow_retreating flag #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, now that I see it, you can put these changes before the rolling_mean_smoothing, as some smoothing will make the animations look nicer. |
fmaussion
approved these changes
Aug 7, 2024
pat-schmitt
reviewed
Aug 12, 2024
oggm/sandbox/distribute_2d.py
Outdated
| mask], | ||
| dim='time') | ||
| if mask.any(): | ||
| # for each increasing time-step use the future time-step |
There was a problem hiding this comment.
here it should read 'past time-step' and not 'future time-step'
|
Thanks @afisc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small addition of an option to not allow sudden glacier (re-)growth in the
distribute_thickness_from_simulationworkflow. This allows for smoother animations, but keep in mind that this can change the area/thickness evolution of the glacier.whats-new.rst