Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inversion now takes ice divides into account #219

Merged
merged 10 commits into from
Apr 17, 2017
Merged

Conversation

fmaussion
Copy link
Member

@fmaussion fmaussion commented Apr 17, 2017

This PR is a bit larger than I wish it would be, and it brakes backwards compatibility. Non-exhaustive list of changes:

  • the inversion formula takes ice divides into account (this changes the thickness estimation locally)
  • the filtering that occurred during the inversion is now happening in a separate task. It has been improved to conserve volume entirely. The implications of this change aren't fully explored
  • had to make some change to remove rasterio warnings and other issues related to Get rid of intermediate DEM files #216 . The differences between rasterio 1.0 and previous is a pain. (Travis still uses 0.36 and so did I).
  • docs improvements

To get something close to backwards compatibility one should set cfg.PARAMS['invert_with_rectangular'] = False in the script. However I would recommend OGGM users NOT to update OGGM until the rest of the workflow can cope with rectangular beds.

@fmaussion fmaussion changed the title WIP Inversion now takes ice divides into account Apr 17, 2017
@fmaussion
Copy link
Member Author

@anoukvlug @bearecinos fyi see message above

@fmaussion fmaussion merged commit 3253fd1 into OGGM:master Apr 17, 2017
@bearecinos
Copy link
Member

bearecinos commented May 12, 2017

sorry I come back to this until now. several questions in the inversion.py :

  1. to make sure that I understand. The last pixels of tidewater out_thick[-5:] are kept as they were without filtering and then restore after filtering?
  2. After running the vol_inversion() task I need to run this new filtering? Before my calving loop starts for example.
  3. Is there any update on using a different bed shape for the las out_thick[-5:] in TW? perhaps could be added as a filtering for tidewater

@fmaussion
Copy link
Member Author

For your purposes I would try to avoid filtering altogether. What would e good for you though is to force the last pixels of the inversion to be rectangular. This should happen in the prepare_for_inversion task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants