Small slopes filtering now happens at the flowline determination #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relatively small change in the code involves quite a bit of change in how the inversion and the numerical model are going to handle unrealistic flowlines in the future. The consequences of this change need to be tested on other glaciers than HEF, but here is the deal: slopes smaller than
cfg.PARAMS['min_slope']
are simply not allowed anymore at the moment the flowlines are created (initialize_flowlines
task).When the threshold is reached, the non-valid areas are expanded until the slope is valid again using a fill-void algorithm. Two cases are possible:
Before:
After:
I expect this change to increase the numerical stability of the model, and automatically avoid completely unrealistic flowlines. It will need some thorough testing on more glaciers to see if it works as expected.