Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial asv support #481

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Add initial asv support #481

merged 2 commits into from
Jun 21, 2018

Conversation

TimoRoth
Copy link
Member

I'm not sure why the dependencies in setup.py were not set.
But they are 100% required for asv to operate at all, and having them setup properly seems like a good idea anyway.

@fmaussion
Copy link
Member

Thanks so much, this is great!

About the setup: I was reluctant to force install the packages because (at least on my system) GDAL needs to be installed manually (with links). I wanted to avoid that people do a simple pip install oggm and expect this to work.

But we have documented the install procedure more than enough, so I guess this is ok now.

Copy link
Member

@fmaussion fmaussion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add a section in the docs explaining how to run the benchmarks locally for testing.

I can take care of this if you want, but I'm also happy if you give it a go!

@fmaussion
Copy link
Member

I think I should release salem also. It's been far too long already: doing a release now

@TimoRoth
Copy link
Member Author

The current situation with setup.py is that it installs oggm without an error even if it doesn't have any chance to then even be successfully imported.
So having the right dependencies in setup.py seems quite a vital sanity check to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants