Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed SRTM download urls #505

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Changed SRTM download urls #505

merged 2 commits into from
Jul 18, 2018

Conversation

matthiasdusch
Copy link
Member

Changes the dead 'droppr.org' url to 'http://srtm.csi.cgiar.org/SRT-ZIP/SRTM_V41/SRTM_Data_GeoTiff/' as proposed by @DavidParkes.

A test to download a SRTM file already exists (test_srtmdownload).
But this test will not download the file if it still exits in the cache. This should probably be adapted.

@fmaussion
Copy link
Member

A test to download a SRTM file already exists (test_srtmdownload).
But this test will not download the file if it still exits in the cache. This should probably be adapted

It should, if you either comment out the @is_download decorator or set

RUN_DOWNLOAD_TESTS = False

to True.

This is for testing locally though, we don't download files from Travis

@matthiasdusch
Copy link
Member Author

My bad. I did not realise the tearDown part of the testcase, which actually deletes the download folder at the end of the test. So cache should not be a problem.

@fmaussion
Copy link
Member

Thanks! Going to merge this but during the time Timo is on holidays the cluster cache won't be updated, which is bad -> @OGGM/oggm-devs don't update OGGM on the cluster, or revert this PR temporarily.

@fmaussion fmaussion merged commit 9fcd55d into OGGM:master Jul 18, 2018
@matthiasdusch matthiasdusch deleted the srtm branch July 18, 2018 09:39
DavidParkes added a commit to DavidParkes/oggm that referenced this pull request Jul 19, 2018
Changed SRTM download urls (OGGM#505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants