Code clean up #124
Merged
Code clean up #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When exporting your mesh from blender in the Ogre Next format (v2). Fixes the OgreMeshTool being passed invalid arguments. Also fixes the V1 or V2 mesh format option in the export dialogue not displaying.
Tangent generating arguments were not being passed to OgreMeshTool.exe when converting mesh.xml to binary format for OgreNext (v2) meshes. There was also a bug where some V2 options were not being displayed in the export dialogue.
Made changes to the README.md file.
Added a section to document the output filename.
1. Fix the plugin trying to access windows registry keys 2. Fixed bug where config settings weren't being saved correctly on plugin unload 3. Implemented better way to show/hide `Preview Mesh` button
1. Removed all references to jMonkey
2. Removed ui/helper.py as all the information was outdated and replaced by the readme
3. Removed code from ui/__init__.py referencing a material viewer (& editor?)
- I got scared because it looked like quite a lot of code could get removed.
- ui/helper.py & ui/material.py were removed. The code in material.py was moved to unused.py
- Potentially the following files could be removed. I don't know enough about how the plugin is used by other people to be sure. It removes quite a lot of code, which to me looks unused due to API changes and unmaintained features:
- properties.py
- game_logic.py
- terrain.py
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are just general code clean up. The first two are straight forward:
This change started to remove a lot of code. I stopped before I got too carried away. It looks to me it looks like there is a lot of code that doesn't work due to API changes or people stopped maintaing it. But I'm not familiar enough with the code or the people using the extra features of the plugin it to make that call.
3. Removed code from
ui/__init__.pyreferencing a material viewer (& editor?)ui/material.pywas removed. The code in material.py was moved tounused.pybecause it looked like someone had spent a lot of time on it and it might be useful for future efforts? I don't know what the correct action to take around this is.