-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Google Healthcare extension? #753
Comments
+1 I'd like that functionality too but I don't believe it's available yet. It would be great if someone could add an example. |
This sounds like a nice value add. A couple of ways to approach this: Option 1
Option 2
If I'm missing the mark, or you think there are alternative implementations worth considering, don't hesitate to chime in ^_^ |
Hi @dannyrb - It would be ideal if one could visit the url @bcli4d provided and then get redirected to a google oauth login / permissions page. Then if you have permissions you would get redirected back to the ohif viewer with the correct tokens to access the study in the original url. There shouldn't need to be any custom servers involved. |
Hi @dannyrb . We currently only expose TCGA images, but there are 21 TCGA cancer types with DICOM images, and Google Healthcare has dedicated a separate dataset/datastore to each in its TCIA public data set. If I understand your proposal, you would have us create and configure a server for each? (Not to mention the 56 other Google Healthcare dataset/datastores.) |
This would definitely be a nice addition! We'd be happy to review a PR.
You don't have to add all of them, you can add the one you need dynamically based on the URL. This is exactly what currently happens via the DICOM Store picker. It erases all other servers and adds a DICOMWeb server for the specific DICOM Store when it is selected, and makes that server active: Viewers/src/googleCloud/DicomStorePickerModal.js Lines 22 to 36 in f547fdf
I think you would need to do this:
If you have configured the OIDC settings then the redirect behaviour should work automatically. We haven't planned to implement this, but we would be happy to review a PR. Hope that helps! |
Erik, Thanks for the suggestions. I think I understand what you propose. I don't have any React experience so might be back for help! Regards, |
Related to #790 |
Our webapp presents the user with a list of DICOM studies related to cases in a cohort that the user has created based on various criteria. The user can then select a one more studies to view in separate tabs. In our current implementation, using OHIF 1.x, I just pass the study ID in the URL. BTW, we don't expose the studylist button.
I'm interested in moving to Google Healthcare as our PACS, but don't see a similar ability to command OHIF 2.0 to open a specific study in a chc datastore via the URL. Ideally, I think I'd like to be able to set the default project/location/dataset/dicomstore in a config file, but then override any of those in the URL. E.G., having configured the default project/location/dataset/dicomstore as chc-tcia/us-central1/foo/bar, I could then override the dataset/dicomstore in the URL. Something like:
https://viewer.ohif.org/dataset/tcga-brca/dicomstore/tcga-brca/StudyInstanceUID/1.3.6...
Is there any such functionality now or planned?
Thanks.
The text was updated successfully, but these errors were encountered: