-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat measurement visibility #2773
Conversation
Make the themeable overlays use a straight configuration value to demonstrate how config point is just an aid to defining and optimizing configuration points.
Codecov Report
@@ Coverage Diff @@
## feat/v3-finding-sites #2773 +/- ##
=========================================================
- Coverage 25.26% 25.13% -0.14%
=========================================================
Files 119 119
Lines 2858 2873 +15
Branches 560 564 +4
=========================================================
Hits 722 722
- Misses 1845 1856 +11
- Partials 291 295 +4
Continue to review full report at Codecov.
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Generally the changes are mostly ok. A couple of things that I think would make it a bit more useful:
I think the user experience is better that way. We can talk tomorrow about how it works. |
|
@wayfarer3130 code is updated with what we discussed internally. Can you take a look please? |
refact code review: visibility all, hotkeys refact code review: revert formatting changes :( refact code review. remove unecessary files refact code review: revert formatting changes :(. Minor jsdocs entry
8ee5200
to
c125031
Compare
Do you need this? If so can you please rebase on v3-stable? |
what is the status on this? do we still want it? @ladeirarodolfo Do you have plan to work on this? |
will revisit this here |
Includes
PR Checklist
@mention
a maintainer to request a review