Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow the mode setup/creation to be async, and provide a few more values to extension/app config/mode setup. #4016

Merged
merged 77 commits into from
Jun 19, 2024

Conversation

wayfarer3130
Copy link
Contributor

Context

Adds the extension/mode loader to the app config setup so that things listed in the loader can be provided/used.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 8ae4550
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6671d2a84b8ccf0008a689c3

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 8ae4550
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6671d2a8e9ce9b000894616e

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 44.37%. Comparing base (41a8d10) to head (7ff16c2).

Files Patch % Lines
platform/app/src/appInit.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4016   +/-   ##
=======================================
  Coverage   44.37%   44.37%           
=======================================
  Files          80       80           
  Lines        1334     1334           
  Branches      327      327           
=======================================
  Hits          592      592           
  Misses        589      589           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 5, 2024

Passing run #4096 ↗︎

0 44 2 0 Flakiness 0

Details:

fix: syntax in babel config
Project: Viewers Commit: 8ae4550afb
Status: Passed Duration: 05:24 💡
Started: Jun 18, 2024 6:45 PM Ended: Jun 18, 2024 6:51 PM

Review all test suite changes for PR #4016 ↗︎

@sedghi
Copy link
Member

sedghi commented May 29, 2024

I understand your intention. I asked Ibrahim to initiate a similar effort for dev dependencies like percy, cypress, docusaurus, etc. Here is his PR: https://github.com/OHIF/Viewers/pull/4188/files

I prefer his approach. What are your thoughts, @wayfarer3130?

@wayfarer3130 wayfarer3130 requested a review from sedghi June 17, 2024 20:46
@wayfarer3130
Copy link
Contributor Author

Running the minimal version is:
yarn install:dev -f
yarn test:e2e:serve

then to switch back:
yarn install -f
yarn test:e2e:serve

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks great i tested it

@sedghi sedghi merged commit 88575c6 into master Jun 19, 2024
9 checks passed
@wayfarer3130 wayfarer3130 deleted the fix/dynamic-config branch June 19, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants