-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow the mode setup/creation to be async, and provide a few more values to extension/app config/mode setup. #4016
Conversation
✅ Deploy Preview for ohif-platform-docs canceled.
|
✅ Deploy Preview for ohif-dev canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4016 +/- ##
=======================================
Coverage 44.37% 44.37%
=======================================
Files 80 80
Lines 1334 1334
Branches 327 327
=======================================
Hits 592 592
Misses 589 589
Partials 153 153 ☔ View full report in Codecov by Sentry. |
Passing run #4096 ↗︎
Details:
Review all test suite changes for PR #4016 ↗︎ |
I understand your intention. I asked Ibrahim to initiate a similar effort for dev dependencies like percy, cypress, docusaurus, etc. Here is his PR: https://github.com/OHIF/Viewers/pull/4188/files I prefer his approach. What are your thoughts, @wayfarer3130? |
extensions/default/src/DicomWebDataSource/utils/fixBulkDataURI.ts
Outdated
Show resolved
Hide resolved
Running the minimal version is: then to switch back: |
b31855f
to
c1d2ef9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks great i tested it
Context
Adds the extension/mode loader to the app config setup so that things listed in the loader can be provided/used.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment