Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): docker build was broken because of imports #4192

Merged
merged 19 commits into from
May 30, 2024
Merged

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented May 30, 2024

Context

will fix this #4172

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented May 30, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 445143d
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6658ac4c35b85f000817a8b2
😎 Deploy Preview https://deploy-preview-4192--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 30, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 445143d
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6658ac4c2ab9850008582f2b
😎 Deploy Preview https://deploy-preview-4192--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title fix/auth fix(docker): docker build was broken because of imports May 30, 2024
Copy link

cypress bot commented May 30, 2024

Passing run #4021 ↗︎

0 44 2 0 Flakiness 0

Details:

fix
Project: Viewers Commit: 445143d362
Status: Passed Duration: 05:18 💡
Started: May 30, 2024 4:54 PM Ended: May 30, 2024 4:59 PM

Review all test suite changes for PR #4192 ↗︎

@sedghi sedghi merged commit d7aa386 into master May 30, 2024
9 checks passed
kiwi-latte pushed a commit to kiwi-latte/ohif-viewers that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants