Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: css variabled theme #205

Merged
merged 10 commits into from
Jul 11, 2020
Merged

feat: css variabled theme #205

merged 10 commits into from
Jul 11, 2020

Conversation

diauweb
Copy link
Member

@diauweb diauweb commented May 25, 2020

Notice this is a draft and not everything is working yet.

Problems:

  • Not covered everything yet
  • JSS Color Manipulator won't work
  • ...

@diauweb
Copy link
Member Author

diauweb commented May 25, 2020

upstream issues
mui/material-ui#12827
mui/material-ui#15588

@render
Copy link

render bot commented Jul 1, 2020

Your Render PR Server at https://oi-wiki-ng-pr-205.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-br5nsooiq56cn5r0uttg.

@OI-wiki OI-wiki deleted a comment from render bot Jul 3, 2020
@OI-wiki OI-wiki deleted a comment from render bot Jul 3, 2020
@OI-wiki OI-wiki deleted a comment from render bot Jul 3, 2020
@OI-wiki OI-wiki deleted a comment from render bot Jul 3, 2020
@OI-wiki OI-wiki deleted a comment from render bot Jul 3, 2020
@OI-wiki OI-wiki deleted a comment from render bot Jul 3, 2020
@render

This comment has been minimized.

@Enter-tainer
Copy link
Member

我们可能需要坐等上游把支持 css var 的 fade 做出来,目前 wip alert 的颜色不太对劲

@Enter-tainer
Copy link
Member

目前显示出现问题的页面:

标签在暗色模式下颜色出错
image

wip alert 在两种颜色模式下都失去了背景
image

如果只有这两处问题的话,是不是可以考虑直接 hack

@diauweb
Copy link
Member Author

diauweb commented Jul 11, 2020

目前显示出现问题的页面:

标签在暗色模式下颜色出错
image

wip alert 在两种颜色模式下都失去了背景
image

如果只有这两处问题的话,是不是可以考虑直接 hack

fixed in 9125ab9

@render
Copy link

render bot commented Jul 11, 2020

Your Render PR Server at https://oi-wiki-ng-pr-205.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-br5nsooiq56cn5r0uttg.

Copy link
Member

@Enter-tainer Enter-tainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Enter-tainer
Copy link
Member

看起来没有更多的 bug 了,先合上好了

@Enter-tainer Enter-tainer merged commit a721e49 into master Jul 11, 2020
@Enter-tainer Enter-tainer deleted the varitheme branch July 11, 2020 12:01
diauweb pushed a commit that referenced this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants