libhtp: delete library version from SONAME #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete library version from SONAME and bump it from 1:0:0 to 2:0:0. Using the library version in the SONAME means that the effective SONAME is bumped each release of libhtp, which have a negative impact in the integration of the library in downstream distros. For example, in Debian, the SONAME is put into the library package name to allow co-existence of different API/ABI versions and to ease upgrade management between versions. The bump from 1 to 2 is made in order to left behind the old scheme. Before this patch: % objdump -p htp/.libs/libhtp.so | grep SONAME SONAME libhtp-0.5.24.so.1 After this patch: % objdump -p htp/.libs/libhtp.so | grep SONAME SONAME libhtp.so.2 Signed-off-by: Arturo Borrero Gonzalez <arturo@debian.org>
Drop sources that aren't included in the suricata release tarball. The most important removal is the docbook-xsl-ns-1.77.1 source, which clearly doesn't belong here. Signed-off-by: Arturo Borrero Gonzalez <arturo@debian.org>
|
Merged this in #155, thanks Arturo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete library version from SONAME and bump it from 1:0:0 to 2:0:0.
Using the library version in the SONAME means that the effective SONAME is
bumped each release of libhtp, which have a negative impact in the integration
of the library in downstream distros.
For example, in Debian, the SONAME is put into the library package name to
allow co-existence of different API/ABI versions and to ease upgrade
management between versions.
The bump from 1 to 2 is made in order to left behind the old scheme.
Before this patch:
% objdump -p htp/.libs/libhtp.so | grep SONAME
SONAME libhtp-0.5.24.so.1
After this patch:
% objdump -p htp/.libs/libhtp.so | grep SONAME
SONAME libhtp.so.2
Signed-off-by: Arturo Borrero Gonzalez arturo@debian.org