-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lua: use lua from crates.io rather than github #11624
Conversation
This allows offline builds to work when this crate is vendored.
Temp: cherry-pick from PR OISF#11624
Temp: cherry-pick from PR OISF#11624
Temp: cherry-pick from PR OISF#11624
Temp: cherry-pick from PR OISF#11624
Temp: cherry-pick from PR OISF#11624
Temp: cherry-pick from PR OISF#11624
Temp: cherry-pick from PR OISF#11624
Is there a ticket for this ? |
There is now: https://redmine.openinfosecfoundation.org/issues/7226 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase with the commit including the ticket number ?
How is this tested ? (should offline build be part of CI ?)
Temp: cherry-pick from PR OISF#11624
Rebase coming. I tested offline. Not sure if GitHub actions can do that. |
Rebase and fix here: #11762 |
This allows offline builds to work when this crate is vendored.
Ticket: https://redmine.openinfosecfoundation.org/issues/7226