Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua: use lua from crates.io rather than github #11624

Closed
wants to merge 1 commit into from

Conversation

jasonish
Copy link
Member

@jasonish jasonish commented Aug 12, 2024

This allows offline builds to work when this crate is vendored.

Ticket: https://redmine.openinfosecfoundation.org/issues/7226

This allows offline builds to work when this crate is vendored.
jlucovsky added a commit to jlucovsky/suricata that referenced this pull request Aug 13, 2024
jlucovsky added a commit to jlucovsky/suricata that referenced this pull request Aug 19, 2024
jlucovsky added a commit to jlucovsky/suricata that referenced this pull request Aug 19, 2024
jlucovsky added a commit to jlucovsky/suricata that referenced this pull request Aug 20, 2024
jlucovsky added a commit to jlucovsky/suricata that referenced this pull request Aug 20, 2024
jlucovsky added a commit to jlucovsky/suricata that referenced this pull request Aug 21, 2024
jlucovsky added a commit to jlucovsky/suricata that referenced this pull request Aug 24, 2024
@catenacyber
Copy link
Contributor

Is there a ticket for this ?

@jasonish
Copy link
Member Author

Is there a ticket for this ?

There is now: https://redmine.openinfosecfoundation.org/issues/7226

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase with the commit including the ticket number ?

How is this tested ? (should offline build be part of CI ?)

jlucovsky added a commit to jlucovsky/suricata that referenced this pull request Aug 31, 2024
@jasonish
Copy link
Member Author

Could you rebase with the commit including the ticket number ?

How is this tested ? (should offline build be part of CI ?)

Rebase coming. I tested offline. Not sure if GitHub actions can do that.

@jasonish
Copy link
Member Author

Rebase and fix here: #11762

@jasonish jasonish closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants